Page MenuHomePhabricator

Update Profile Menu diviner
ClosedPublic

Authored by chad on Feb 3 2017, 10:22 PM.
Tags
None
Referenced Files
F13246448: D17309.diff
Thu, May 23, 10:26 AM
F13241974: D17309.diff
Thu, May 23, 1:10 AM
F13237933: D17309.id41630.diff
Tue, May 21, 4:05 PM
F13234863: D17309.id.diff
Tue, May 21, 3:52 AM
F13234862: D17309.id41633.diff
Tue, May 21, 3:52 AM
F13234861: D17309.id41630.diff
Tue, May 21, 3:52 AM
F13226442: D17309.id41633.diff
Sun, May 19, 8:47 PM
F13200407: D17309.diff
Mon, May 13, 11:53 PM
Subscribers

Details

Summary

Ref T12174, Updates documentation to better match current functionality.

Test Plan

I keep getting exceptions trying to generate diviner locally, not sure what's up.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

BUILDING GRAPH CACHE
Found 6,914 obsolete atoms in graph.
Found 8,932 new atoms in graph.
Propagating changes through the graph.
[2017-02-03 22:23:45] ERROR 8: unserialize(): Error at offset 185 of 907 bytes at [/var/www/html/dev/core/lib/libphutil/src/cache/PhutilDirectoryKeyValueCache.php:58]
arcanist(head=master, ref.master=ade25facfdf2), corgi(head=master, ref.master=aebec8206183), instances(head=master, ref.master=0ddfd7990f6e), libcore(), phabricator(head=diviner-profile-menu, ref.master=42743810e914, ref.diviner-profile-menu=8eb10f48320e), phutil(head=master, ref.master=9d85dfab0f53), services(head=master, ref.master=b5cef1ac31ff)
  #0 unserialize(string) called at [<phutil>/src/cache/PhutilDirectoryKeyValueCache.php:58]
  #1 PhutilDirectoryKeyValueCache::getKeys(array) called at [<phutil>/src/cache/PhutilKeyValueCacheProxy.php:21]

Blanket fix that might resolve the unserialize() is to try bin/diviner generate --clean, although that takes quite a while.

(I get some different weirdness running diviner generate locally, maybe a PHP 7 issue? Did you stay on PHP7 or drop back to PHP5? I don't see the unserialize issue, though.)

If that doesn't work you can also just like copy/paste the whole document into a task or comment and look at the preview, which is 95% accurate and good enough to catch stuff like misspelled {icon} or whatever.

src/docs/user/userguide/profile_menu.diviner
130–142

"Let's" -> "Lets": not "Let us you..."

131

"purely" -> "Purely" (beginning of sentence)

This revision is now accepted and ready to land.Feb 4 2017, 12:39 AM
This revision was automatically updated to reflect the committed changes.