Page MenuHomePhabricator

When a viewer can't see some of a dashboard's panels, only hide those panels
ClosedPublic

Authored by epriestley on Feb 3 2017, 5:58 PM.
Tags
None
Referenced Files
F13232750: D17308.diff
Tue, May 21, 1:28 AM
F13187781: D17308.diff
Sat, May 11, 4:44 AM
F13184244: D17308.id.diff
Fri, May 10, 5:03 PM
Unknown Object (File)
Tue, May 7, 7:56 AM
Unknown Object (File)
Fri, May 3, 7:38 AM
Unknown Object (File)
Sun, Apr 28, 6:41 PM
Unknown Object (File)
Sat, Apr 27, 1:32 AM
Unknown Object (File)
Thu, Apr 25, 1:39 AM
Subscribers
None

Details

Summary

Ref T12174. Ref T8033. Currently, if you can't see one panel on a dashboard, you can't see the dashboard at all. This is confusing and hard to debug.

Improve this behavior at least slightly: render the dashboard, with a big "you can't see this" panel in place of any panels you can't see. This should at least make the behavior obvious, even if it isn't the best or most comprehensive way we can handle it in all cases.

Test Plan

Screen Shot 2017-02-03 at 9.53.58 AM.png (935×1 px, 130 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable