Differential D17298

Remove menu item pinning from Home and Favorites profile menus
ClosedPublic
Actions

Authored by epriestley on Feb 2 2017, 3:40 PM.

Tags

None

Referenced Files

	F13241288: D17298.id41605.diff
	Wed, May 22, 8:01 PM

	F13230701: D17298.diff
	Mon, May 20, 11:16 PM

	F13228228: D17298.id41617.diff
	Mon, May 20, 8:05 AM

	F13213077: D17298.diff
	Fri, May 17, 7:21 AM

	F13180387: D17298.id41617.diff
	Wed, May 8, 11:38 PM

	F13175076: D17298.diff
	Wed, May 8, 3:10 AM

	Unknown Object (File)
	Tue, May 7, 5:06 AM

	Unknown Object (File)
	Mon, May 6, 4:17 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12174: Home Menu Errata

Commits

rPd182d7eaf1d1: Remove menu item pinning from Home and Favorites profile menus

Summary

Home now always uses the topmost item (falling back to "magic home") and no longer supports pinning. If any personal item may be a default item, it will always be picked over any global item.
Favorites doesn't use defaults anyway, but no longer has misleading UI suggesting it might.

Test Plan

Saw no pinning UI on Home/Favorites.
Added a personal dashboard on Home, it automatically became the new default.
Pinned stuff normally on Projects.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 2 2017, 3:40 PM

Harbormaster completed remote builds in B15503: Diff 41605.Feb 2 2017, 3:41 PM

epriestley mentioned this in T12174: Home Menu Errata.Feb 2 2017, 3:44 PM

chad accepted this revision.Feb 2 2017, 4:41 PM

This revision is now accepted and ready to land.Feb 2 2017, 4:41 PM

Closed by commit rPd182d7eaf1d1: Remove menu item pinning from Home and Favorites profile menus (authored by epriestley, committed by epriestley). · Explain WhyFeb 3 2017, 1:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorProfileMenuEngine.php

43 lines

Diff 41617

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...