Page MenuHomePhabricator

Allow "Magic Home" to be hidden
ClosedPublic

Authored by epriestley on Feb 1 2017, 6:01 PM.
Tags
None
Referenced Files
F13287595: D17289.diff
Tue, Jun 4, 9:00 AM
F13275125: D17289.diff
Fri, May 31, 4:25 AM
F13261194: D17289.diff
Mon, May 27, 12:47 AM
F13243716: D17289.diff
Thu, May 23, 4:09 AM
F13234905: D17289.id41591.diff
Tue, May 21, 3:54 AM
F13234903: D17289.id41588.diff
Tue, May 21, 3:54 AM
F13234902: D17289.id.diff
Tue, May 21, 3:54 AM
F13226506: D17289.id41588.diff
Sun, May 19, 9:12 PM
Subscribers
None

Details

Summary

Ref T12174. Fallback behavior on this already appears to be sensible.

Test Plan
  • Hid "Magic Home".
  • Viewed homepage with no dashboards on the menu.
  • Saw "Magic Home" content, with no item in the menu selected, which seems reasonable.

Screen Shot 2017-02-01 at 10.00.50 AM.png (780×1 px, 172 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I can clean the UX up from here. I thought this would have been more difficult.

This revision is now accepted and ready to land.Feb 1 2017, 6:02 PM

Yeah, I'm a little surprised the fallback already works since I also expected it to be a little more involved. Possible that it only appears to work and will need a little more effort, but should be easy to fix if that's true.

This revision was automatically updated to reflect the committed changes.