Put Project "Manage" item back
ClosedPublic
Actions

Authored by epriestley on Jan 31 2017, 7:57 PM.

Tags

None

Referenced Files

	F13261246: D17275.diff
	Mon, May 27, 12:50 AM

	F13257380: D17275.id41562.diff
	Sun, May 26, 12:11 AM

	F13243786: D17275.diff
	Thu, May 23, 4:13 AM

	F13234845: D17275.id41560.diff
	Tue, May 21, 3:51 AM

	F13234844: D17275.id.diff
	Tue, May 21, 3:51 AM

	F13234843: D17275.id41562.diff
	Tue, May 21, 3:51 AM

	F13222254: D17275.diff
	Sun, May 19, 3:26 AM

	F13216121: D17275.id41560.diff
	Fri, May 17, 10:26 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12174: Home Menu Errata

Commits

rP2a527a51f26d: Put Project "Manage" item back

Summary

Ref T12174. This isn't really a "newManageItem()" since Projects have a separate manage screen.

That is, I incorrectly changed the "Manage [This Project]" item into a "Edit Menu" item, so some options (like "Archive Project") incorrectly became inaccessible.

Test Plan

Viewed a project, saw the right menu item, clicked it, could archive/etc project. Also edited the menu.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 31 2017, 7:57 PM

Harbormaster completed remote builds in B15458: Diff 41560.Jan 31 2017, 7:58 PM

chad accepted this revision.Jan 31 2017, 8:02 PM

This revision is now accepted and ready to land.Jan 31 2017, 8:02 PM

Closed by commit rP2a527a51f26d: Put Project "Manage" item back (authored by epriestley, committed by epriestley). · Explain WhyJan 31 2017, 8:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

engine/

PhabricatorProjectProfileMenuEngine.php

4 lines

Diff 41562

View Options

src/applications/project/engine/PhabricatorProjectProfileMenuEngine.php

Put Project "Manage" item backClosedPublicActions