Differential D17273

Replace ProfileMenu bugs with different bugs
ClosedPublic
Actions

Authored by epriestley on Jan 31 2017, 7:08 PM.

Tags

None

Referenced Files

	F13281796: D17273.diff
	Sun, Jun 2, 11:13 AM

	F13243308: D17273.diff
	Thu, May 23, 3:43 AM

	F13223150: D17273.diff
	Sun, May 19, 4:20 AM

	F13200436: D17273.id41555.diff
	Tue, May 14, 12:05 AM

	F13200435: D17273.id.diff
	Tue, May 14, 12:05 AM

	F13200434: D17273.id41556.diff
	Tue, May 14, 12:05 AM

	F13200403: D17273.diff
	Mon, May 13, 11:52 PM

	F13183764: D17273.diff
	Fri, May 10, 12:12 PM

View All 96 Files

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12174: Home Menu Errata

Commits

rPf23bfccc0467: Replace ProfileMenu bugs with different bugs

Summary

Ref T12174. This fixes more bugs than it creates, I think:

Dashboards now show the whole menu.
Project and home items now show selected state correctly.
The "choose global vs personal" thing is now part of MenuEngine, and the same code builds it for Home and Favorites.
Home now handles defaults correctly, I think.

Maybe regression/bad/still buggy?:

Mobile home is now whatever the default thing was, not the menu?
Title for dashboard content or other items that render their own content is incorrectly always "Configure Menu" (this was preexisting).

Test Plan

Created, edited, reordered, disabled, deleted and pinned personal and global items on home, favorites, and projects.
Also checked User profiles.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 31 2017, 7:08 PM

Harbormaster completed remote builds in B15453: Diff 41555.Jan 31 2017, 7:09 PM

Will this support Global / Personal for projects to? That would have "Global" be things applied to all projects, and "Personal" being just that project. However these only seem useful if we can pass in projectPHID to alter what the Global link does...

I dont know we'll do that, just spitballing....

chad accepted this revision.Jan 31 2017, 7:18 PM

This revision is now accepted and ready to land.Jan 31 2017, 7:18 PM

epriestley added inline comments.Jan 31 2017, 7:21 PM

src/applications/project/engine/PhabricatorProjectProfileMenuEngine.php
10–12	It keeps projects as-is because of this, which turns off the "personal/custom" option. Overall, this probably moves us slightly closer to a per-project vs all-projects mode but doesn't get us there, the "custom/personal" mode is still fairly specific to being a personal-per-viewer mode.

Closed by commit rPf23bfccc0467: Replace ProfileMenu bugs with different bugs (authored by epriestley, committed by epriestley). · Explain WhyJan 31 2017, 7:22 PM

This revision was automatically updated to reflect the committed changes.

I'm going to deploy this now and we can see how bad I am at testing.

hmm I found bug :)

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

12 lines

applications/

base/

PhabricatorApplication.php

8 lines

favorites/

application/

PhabricatorFavoritesApplication.php

3 lines

controller/

PhabricatorFavoritesMainController.php

PhabricatorFavoritesMenuItemController.php

10 lines

engine/

PhabricatorFavoritesProfileMenuEngine.php

9 lines

engineextension/

PhabricatorFavoritesMainMenuBarExtension.php

14 lines

home/

application/

PhabricatorHomeApplication.php

9 lines

controller/

PhabricatorHomeController.php

10 lines

PhabricatorHomeMainController.php

PhabricatorHomeMenuController.php

PhabricatorHomeMenuItemController.php

18 lines

engine/

PhabricatorHomeProfileMenuEngine.php

15 lines

menuitem/

PhabricatorHomeManageProfileMenuItem.php

PhabricatorHomeProfileMenuItem.php

9 lines

	view/
	controller/

	PHUIHomeView.php
	PhabricatorHomeMainController.php

53 lines

project/

engine/

PhabricatorProjectProfileMenuEngine.php

8 lines

search/

engine/

PhabricatorProfileMenuEngine.php

266 lines

menuitem/

PhabricatorDashboardProfileMenuItem.php

6 lines

query/

PhabricatorProfileMenuItemConfigurationQuery.php

1 line

storage/

PhabricatorProfileMenuItemConfiguration.php

8 lines

	search/	menuitem/
	home/	menuitem/

	PhabricatorManageProfileMenuItem.php
	PhabricatorHomeManageProfileMenuItem.php

28 lines

Diff 41556

src/__phutil_library_map__.php

Loading...

src/applications/base/PhabricatorApplication.php

Loading...

src/applications/favorites/application/PhabricatorFavoritesApplication.php

Loading...

src/applications/favorites/controller/PhabricatorFavoritesMainController.php

Loading...

src/applications/favorites/controller/PhabricatorFavoritesMenuItemController.php

Loading...

src/applications/favorites/engine/PhabricatorFavoritesProfileMenuEngine.php

Loading...

src/applications/favorites/engineextension/PhabricatorFavoritesMainMenuBarExtension.php

Loading...

src/applications/home/application/PhabricatorHomeApplication.php

Loading...

src/applications/home/controller/PhabricatorHomeController.php

Loading...

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...

src/applications/home/controller/PhabricatorHomeMenuController.php

Loading...

src/applications/home/controller/PhabricatorHomeMenuItemController.php

Loading...

src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php

Loading...

src/applications/home/menuitem/PhabricatorHomeManageProfileMenuItem.php

Loading...

src/applications/home/menuitem/PhabricatorHomeProfileMenuItem.php

Loading...

src/applications/home/view/PHUIHomeView.php

Loading...

src/applications/project/engine/PhabricatorProjectProfileMenuEngine.php

Loading...

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...

src/applications/search/menuitem/PhabricatorDashboardProfileMenuItem.php

Loading...

src/applications/search/menuitem/PhabricatorManageProfileMenuItem.php

Loading...

src/applications/search/query/PhabricatorProfileMenuItemConfigurationQuery.php

Loading...

src/applications/search/storage/PhabricatorProfileMenuItemConfiguration.php

Loading...