Prevent users from resigning from audits they've already resigned from
ClosedPublic
Actions

Authored by epriestley on Jan 11 2017, 11:27 PM.

Tags

None

Referenced Files

	F13275122: D17187.diff
	Fri, May 31, 4:25 AM

	F13261198: D17187.diff
	Mon, May 27, 12:47 AM

	F13243715: D17187.diff
	Thu, May 23, 4:09 AM

	F13234875: D17187.id41332.diff
	Tue, May 21, 3:53 AM

	F13223244: D17187.diff
	Sun, May 19, 4:25 AM

	F13210947: D17187.id41330.diff
	Fri, May 17, 5:21 AM

	F13178194: D17187.diff
	Wed, May 8, 8:15 PM

	Unknown Object (File)
	Sat, May 4, 5:53 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10978: Modernize Audit

Commits

rPb941331bdfe6: Prevent users from resigning from audits they've already resigned from

Summary

Ref T10978. Since "Resigned" is a status in Audit, you could repeatedly resign. This is confusing; prevent it.

Test Plan

Tried to resign twice; was only allowed to resign once.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 11 2017, 11:27 PM

Harbormaster completed remote builds in B15217: Diff 41330.Jan 11 2017, 11:28 PM

chad accepted this revision.Jan 11 2017, 11:42 PM

This revision is now accepted and ready to land.Jan 11 2017, 11:42 PM

Closed by commit rPb941331bdfe6: Prevent users from resigning from audits they've already resigned from (authored by epriestley, committed by epriestley). · Explain WhyJan 12 2017, 12:29 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

xaction/

DiffusionCommitAuditTransaction.php

17 lines

DiffusionCommitResignTransaction.php

6 lines

Diff 41332

View Options

src/applications/diffusion/xaction/DiffusionCommitAuditTransaction.php