Fix RRULE bugs with week numbers for leading and trailing partial weeks
ClosedPublic
Actions

Authored by epriestley on Sep 28 2016, 12:08 AM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

Summary

Ref T10747. I only got this partially right:

When the last week of the year has less than 4 days, it's counted as the first week of the next year.
When the first week of the year has less than 4 days, it's counted as the last week of the prior year.

These rules are sort of crazy, but they work now.

Test Plan

Unit tests now pass.

Repository

rPHU libphutil

Lint

Lint Not Applicable

Unit

Tests Not Applicable

epriestley retitled this revision from to Fix RRULE bugs with week numbers for leading and trailing partial weeks.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php
628–633	I also added this safety check so we don't loop forever with contradictory rules like "BYWEEKNO=1, BYYEARDAY=300" (which can never occur, and might also be invalid -- I haven't tried to add all the "X must not be present if Y is present" checks from the spec yet) or because of bugs in the implementation.