Page MenuHomePhabricator

Make .ics export less scary and attach .ics files to event mail
ClosedPublic

Authored by epriestley on Sep 15 2016, 2:01 PM.
Tags
None
Referenced Files
F13283453: D16559.diff
Sun, Jun 2, 2:43 PM
F13267121: D16559.id.diff
Wed, May 29, 1:36 AM
F13249198: D16559.diff
Fri, May 24, 7:38 AM
F13238545: D16559.id39855.diff
Tue, May 21, 7:50 PM
F13236232: D16559.id.diff
Tue, May 21, 8:50 AM
F13227383: D16559.id39852.diff
Mon, May 20, 3:01 AM
F13216999: D16559.id39852.diff
Sat, May 18, 3:22 AM
F13201366: D16559.diff
Tue, May 14, 11:20 AM
Subscribers
None

Details

Summary

Ref T10747.

  • Remove the warning dialog since these files don't seem to do anything confusing/problematic in Calendar.app or Google Calendar. Those importers generally need to be defensive about how they handle random ".ics" files from arbitrary third parties anyway, and this makes testing imports easier since we have a GET-table ".ics" URI for public events.
  • Attach ".ics" files to email.
Test Plan
  • Clicked "Export as .ics", got an ICS file.
  • Used "bin/mail show-outbound" to review an ICS attachment, although I don't actually have real mail set up locally so this may still be a little funky.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Make .ics export less scary and attach .ics files to event mail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 15 2016, 2:40 PM
This revision was automatically updated to reflect the committed changes.