Page MenuHomePhabricator
Differential D16446

Added application name to the typeahead results for doc type search
ClosedPublic
Actions

Authored by jcox on Aug 24 2016, 10:11 PM.
Tags
None
Referenced Files
F13274328: D16446.diff
Fri, May 31, 3:35 AM
F13272221: D16446.id39551.diff
Thu, May 30, 10:32 AM
F13260385: D16446.diff
Sun, May 26, 11:51 PM
F13242715: D16446.diff
Thu, May 23, 3:02 AM
F13236159: D16446.id.diff
Tue, May 21, 8:30 AM
F13228034: D16446.id39561.diff
Mon, May 20, 6:28 AM
F13221068: D16446.diff
Sun, May 19, 2:15 AM
F13214743: D16446.id39562.diff
Fri, May 17, 12:37 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T10951: Search shows document types corresponding to disabled apps
Commits
rPd135b3f2d56f: Added application name to the typeahead results for doc type search
Summary

Ref T10951. This adds the application name as an attribute below the document type in the UI for doc type search.

Test Plan

Verify that the application name appears as an attribute on the document type results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jcox updated this revision to Diff 39551.Aug 24 2016, 10:11 PM
jcox retitled this revision from to Added application name to the typeahead results for doc type search.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
jcox added a task: T10951: Search shows document types corresponding to disabled apps.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 24 2016, 10:11 PM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Aug 25 2016, 2:21 PM
epriestley added a reviewer: epriestley.
This revision is now accepted and ready to land.Aug 25 2016, 2:21 PM
jcox updated this revision to Diff 39561.Aug 25 2016, 3:16 PM
jcox edited edge metadata.

Made line shorter

Herald added a subscriber: Korvin. · View Herald TranscriptAug 25 2016, 3:16 PM
Closed by commit rPd135b3f2d56f: Added application name to the typeahead results for doc type search (authored by jcox, committed by jcox). · Explain WhyAug 25 2016, 3:26 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D16459: Converted the pinned applications selector to a typeahead..Aug 26 2016, 5:22 PM

Revision Contents
Changeset List

PathSize
src/
applications/
search/
typeahead/
16 lines

Diff 39562

View Options

src/applications/search/typeahead/PhabricatorSearchDocumentTypeDatasource.php

Loading...
Phabricator · Built by Phacility