Paths

Table of Contentst

horribly fix plain-text email for modular transactions
ClosedPublic
Actions

Authored by avivey on Jul 8 2016, 12:03 AM.

Tags

None

Referenced Files

	F13284303: D16251.id39091.diff
	Mon, Jun 3, 3:29 AM

	F13258364: D16251.id39094.diff
	Sun, May 26, 8:37 AM

	F13257231: D16251.id39091.diff
	Sat, May 25, 9:41 PM

	F13230964: D16251.diff
	Mon, May 20, 11:28 PM

	F13200990: D16251.id39091.diff
	Tue, May 14, 6:57 AM

	F13191836: D16251.id39094.diff
	Sun, May 12, 1:08 AM

	F13186122: D16251.diff
	Sat, May 11, 3:26 AM

	Unknown Object (File)
	Tue, May 7, 6:13 AM

View All Files

Subscribers

epriestley

Tokens

"Y So Serious" token, awarded by chad."Orange Medal" token, awarded by yelirekim.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9789: Make it easier to write custom transaction types

Commits

rPb656c87e3756: horribly fix plain-text email for modular transactions

Summary

This is the quickest and dirtiest fix I could come up with.

PhabricatorApplicationTransaction::getTitleForMail() is using clone $this, which doesn't actually effect implementation.
Ref T9789.

Test Plan

update paste comment, get plaintext mail.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey updated this revision to Diff 39091.Jul 8 2016, 12:03 AM

avivey retitled this revision from to horribly fix plain-text email for modular transactions.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added a task: T9789: Make it easier to write custom transaction types.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 8 2016, 12:03 AM

Herald added a subscriber: epriestley. · View Herald Transcript

avivey updated this object.Jul 8 2016, 12:03 AM

avivey edited edge metadata.

yelirekim awarded a token.Jul 8 2016, 12:05 AM

(The clone might be in case the method throws? Doesn't seem like a big deal either way.)

This revision is now accepted and ready to land.Jul 8 2016, 12:06 AM

Closed by commit rPb656c87e3756: horribly fix plain-text email for modular transactions (authored by avivey, committed by avivey). · Explain WhyJul 8 2016, 12:17 AM

This revision was automatically updated to reflect the committed changes.

chad awarded a token.Jul 8 2016, 12:38 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorModularTransaction.php

9 lines

Diff 39094

View Options

src/applications/transactions/storage/PhabricatorModularTransaction.php

horribly fix plain-text email for modular transactionsClosedPublicActions