Differential D16214

Render parent and child tasks in Maniphest with a graph trace
ClosedPublic
Actions

Authored by epriestley on Jul 1 2016, 3:52 PM.

Tags

None

Referenced Files

	F13211283: D16214.diff
	Fri, May 17, 5:38 AM

	F13196539: D16214.diff
	Sun, May 12, 11:21 PM

	F13176186: D16214.id39009.diff
	Wed, May 8, 11:22 AM

	Unknown Object (File)
	Sun, May 5, 11:57 AM

	Unknown Object (File)
	Sun, May 5, 11:57 AM

	Unknown Object (File)
	Sun, May 5, 11:57 AM

	Unknown Object (File)
	Sun, May 5, 11:57 AM

	Unknown Object (File)
	Fri, May 3, 5:08 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4788: Allow "Edit Dependencies" both ways (blocking and depending)

Commits

rP0a132e468fc4: Render parent and child tasks in Maniphest with a graph trace

Summary

Ref T4788. This seems reasonable locally, but not sure how it will feel on real data. Might need some tweaks, or might just be a terrible idea.

Test Plan

Screen Shot 2016-07-01 at 8.50.06 AM.png (367×573 px, 42 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39003.Jul 1 2016, 3:52 PM

epriestley retitled this revision from to Render parent and child tasks in Maniphest with a graph trace.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4788: Allow "Edit Dependencies" both ways (blocking and depending).

This also fixes two bugs:

I accidentally removed "Create Subtask" from the UI, put it back.
One bug with ObjectGraph on objects with no relationships.

This graph also renders like the commit/revision graphs do, with children first. That's consistent with the other applications, but we might want to flip it for tasks.

With commits and revisions, you generally work from parent to child (e.g., you have to review "A" before you review "B").

But with tasks, you generally work from child to parent (e.g., you have to "Pick Lemons" before you can "Squeeze Lemons").

Flip order, so parents are first: poking at some more realistic data a bit, I think this feels better.
Fix a rendering issue with leaf nodes with no parents.

This still has a couple of rendering bugs with certain tree shapes, but I'll get some test coverage on this and nail those down in a followup. These graphs can have shapes that commit graphs in repositories usually can not.

Here's an example -- still readable, just not as clean as it should be:

Screen Shot 2016-07-01 at 9.05.58 AM.png (363×382 px, 40 KB)

such enterprise.

This revision is now accepted and ready to land.Jul 1 2016, 4:10 PM

Closed by commit rP0a132e468fc4: Render parent and child tasks in Maniphest with a graph trace (authored by epriestley, committed by epriestley). · Explain WhyJul 1 2016, 5:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

maniphest/

controller/

ManiphestTaskDetailController.php

22 lines

storage/

ManiphestTask.php

4 lines

search/

relationship/

PhabricatorObjectRelationshipList.php

6 lines

infrastructure/

diff/

view/

PHUIDiffGraphView.php

27 lines

graph/

ManiphestTaskGraph.php

87 lines

PhabricatorObjectGraph.php

2 lines

Diff 39009

src/__phutil_library_map__.php

Loading...

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...

src/applications/maniphest/storage/ManiphestTask.php

Loading...

src/applications/search/relationship/PhabricatorObjectRelationshipList.php

Loading...

src/infrastructure/diff/view/PHUIDiffGraphView.php

Loading...

src/infrastructure/graph/ManiphestTaskGraph.php

Loading...

src/infrastructure/graph/PhabricatorObjectGraph.php

Loading...