Fix spurious timeline entry for badges
ClosedPublic
Actions

Authored by chad on Jun 22 2016, 8:00 PM.

Tags

None

Referenced Files

	F13262840: D16169.id38895.diff
	Mon, May 27, 4:21 AM

	F13208516: D16169.id.diff
	Thu, May 16, 4:38 PM

	F13208366: D16169.diff
	Thu, May 16, 2:44 PM

	F13183781: D16169.id38895.diff
	Fri, May 10, 12:28 PM

	F13182941: D16169.id.diff
	Fri, May 10, 5:19 AM

	Unknown Object (File)
	Apr 28 2024, 12:35 AM

	Unknown Object (File)
	Apr 9 2024, 11:15 AM

	Unknown Object (File)
	Mar 27 2024, 11:53 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T11164: Badges: Unwanted entry at the history

Commits

rPa75eea763770: Fix spurious timeline entry for badges

Summary

Fixes T11164. At least, this fixes it locally for me. I don't know how to code. Copy Pasta!

Test Plan

Change name, don't see extra timeline entry on quality set anymore.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 12776
Build 16263: Run Core Tests
Build 16262: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 38895.Jun 22 2016, 8:00 PM

chad retitled this revision from to Fix spurious timeline entry for badges.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T11164: Badges: Unwanted entry at the history.

Herald added a subscriber: Korvin. · View Herald TranscriptJun 22 2016, 8:00 PM

epriestley accepted this revision.Jun 22 2016, 8:20 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 22 2016, 8:20 PM

chad closed this revision.Jun 22 2016, 8:26 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

editor/

PhabricatorBadgesEditor.php

2 lines

storage/

PhabricatorBadgesTransaction.php

4 lines

Diff 38895

View Options

src/applications/badges/editor/PhabricatorBadgesEditor.php