Page MenuHomePhabricator
Differential D16163

Drive modular task relationships through a new "relationships" controller
ClosedPublic
Actions

Authored by epriestley on Jun 22 2016, 3:15 PM.
Tags
None
Referenced Files
F13281364: D16163.diff
Sun, Jun 2, 10:35 AM
F13256319: D16163.id38887.diff
Sat, May 25, 11:09 AM
F13242734: D16163.diff
Thu, May 23, 3:03 AM
F13228496: D16163.diff
Mon, May 20, 9:53 AM
F13221166: D16163.diff
Sun, May 19, 2:19 AM
F13220239: D16163.id38881.diff
Sun, May 19, 12:11 AM
F13202246: D16163.diff
Tue, May 14, 10:26 PM
F13182084: D16163.id.diff
Thu, May 9, 7:32 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11179: Figure out what to do with "Edit Blocking Tasks", "Edit Differential Revisions" and "Edit Pholio Mocks"
Commits
rPb5d90b4714b2: Drive modular task relationships through a new "relationships" controller
Summary

Ref T11179. This is basically a "pro" controller to replace the SearchAttach controller. It does basically the same stuff, just in a (mostly) more modern and modular way.

Test Plan
  • Added and removed mocks.
  • Added and removed revisions.
  • Everything worked just like it did before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38881.Jun 22 2016, 3:15 PM
epriestley retitled this revision from to Drive modular task relationships through a new "relationships" controller.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11179: Figure out what to do with "Edit Blocking Tasks", "Edit Differential Revisions" and "Edit Pholio Mocks".
chad accepted this revision.Jun 22 2016, 4:43 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2016, 4:43 PM
Closed by commit rPb5d90b4714b2: Drive modular task relationships through a new "relationships" controller (authored by epriestley, committed by epriestley). · Explain WhyJun 22 2016, 6:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 38887

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/relationship/ManiphestTaskHasCommitRelationship.php

Loading...
View Options

src/applications/maniphest/relationship/ManiphestTaskHasMockRelationship.php

Loading...
View Options

src/applications/maniphest/relationship/ManiphestTaskHasRevisionRelationship.php

Loading...
View Options

src/applications/search/application/PhabricatorSearchApplication.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchRelationshipController.php

Loading...
View Options

src/applications/search/relationship/PhabricatorObjectRelationship.php

Loading...
View Options

src/applications/search/relationship/PhabricatorObjectRelationshipList.php

Loading...
Phabricator · Built by Phacility