Page MenuHomePhabricator

Embed videos in Remarkup at actual size
ClosedPublic

Authored by epriestley on Jun 7 2016, 9:55 PM.
Tags
None
Referenced Files
F13239475: D16076.id38681.diff
Wed, May 22, 3:30 AM
F13228685: D16076.diff
Mon, May 20, 11:20 AM
F13221768: D16076.diff
Sun, May 19, 3:02 AM
F13213480: D16076.id38681.diff
Fri, May 17, 7:48 AM
F13204272: D16076.diff
Wed, May 15, 12:27 AM
F13188996: D16076.diff
Sat, May 11, 5:39 AM
Unknown Object (File)
Tue, May 7, 7:27 AM
Unknown Object (File)
Fri, May 3, 6:18 AM
Subscribers
None

Details

Summary

Ref T6916. Current rules tend to make videos gigantic. Just embed them at actual size, scaling them down if they're too big to fit.

Browsers generally provide some kind of "expand / fullscreen" element automatically anyway.

Test Plan

Viewed videos locally, saw them sized a little more reasonably.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Embed videos in Remarkup at actual size.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 9:58 PM
This revision was automatically updated to reflect the committed changes.