Page MenuHomePhabricator
Differential D16074

Use "internal" smoothing for code diffs in Arcanist
ClosedPublic
Actions

Authored by epriestley on Jun 7 2016, 8:45 PM.
Tags
None
Referenced Files
F13213072: D16074.diff
Fri, May 17, 7:20 AM
F13206071: D16074.id38680.diff
Wed, May 15, 4:55 AM
F13183196: D16074.id38680.diff
Fri, May 10, 7:29 AM
F13182989: D16074.diff
Fri, May 10, 5:49 AM
Unknown Object (File)
Tue, May 7, 5:05 AM
Unknown Object (File)
Fri, May 3, 2:25 AM
Unknown Object (File)
Tue, Apr 30, 4:16 PM
Unknown Object (File)
Mon, Apr 29, 1:55 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7643: Improve prose diffs (was: description changes don't generate usable diffs)
Commits
rARCc75b671b221a: Use "internal" smoothing for code diffs in Arcanist
Summary

Ref T7643. This moves the prefix/suffix smoothing behavior back to the old one, which seems better for code diffs.

Test Plan

arc unit --everything

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38676.Jun 7 2016, 8:45 PM
epriestley retitled this revision from to Use "internal" smoothing for code diffs in Arcanist.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7643: Improve prose diffs (was: description changes don't generate usable diffs).
chad accepted this revision.Jun 7 2016, 8:49 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 7 2016, 8:49 PM
Closed by commit rARCc75b671b221a: Use "internal" smoothing for code diffs in Arcanist (authored by epriestley, committed by epriestley). · Explain WhyJun 7 2016, 9:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
difference/
2 lines

Diff 38680

View Options

src/difference/ArcanistDiffUtils.php

Loading...
Phabricator · Built by Phacility