Page MenuHomePhabricator
Differential D15913

Use "fa-shopping-bag" instead of "fa-list-alt" for Owners package icon
ClosedPublic
Actions

Authored by epriestley on May 13 2016, 5:45 PM.
Tags
None
Referenced Files
F13245412: D15913.diff
Thu, May 23, 6:00 AM
F13236178: D15913.id38329.diff
Tue, May 21, 8:38 AM
F13235989: D15913.diff
Tue, May 21, 7:27 AM
F13200271: D15913.id38317.diff
Mon, May 13, 10:46 PM
F13195792: D15913.diff
Sun, May 12, 10:37 PM
F13187316: D15913.id.diff
Sat, May 11, 4:27 AM
F13184055: D15913.id38329.diff
Fri, May 10, 2:44 PM
F13182653: D15913.diff
Fri, May 10, 12:41 AM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by eadler.

Details

Reviewers
chad
Maniphest Tasks
T10939: Support for OWNERS files
Commits
rP4ba4cb971178: Use "fa-shopping-bag" instead of "fa-list-alt" for Owners package icon
Summary

Ref T10939. These appear in "Subscribers" tokenizers now and we got a maybe slightly better icon in the last FA update: instead of .

(I don't feel strongly about this, the old icon just doesn't seem very evocative.)

Test Plan

o.( O___O ).o

Screen Shot 2016-05-13 at 10.45.09 AM.png (150×415 px, 17 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38317.May 13 2016, 5:45 PM
epriestley retitled this revision from to Use "fa-shopping-bag" instead of "fa-list-alt" for Owners package icon.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10939: Support for OWNERS files.
eadler awarded a token.May 13 2016, 5:48 PM
chad accepted this revision.May 13 2016, 7:29 PM
chad edited edge metadata.

I thought it was , though maybe thats Owners in general.

This revision is now accepted and ready to land.May 13 2016, 7:29 PM
epriestley added a comment.May 14 2016, 12:17 AM

Ah, yeah, I think so. We should possibly make them consistent at some point -- we probably need something similar for T5055 eventually too, although maybe we'll get another round of FA updates by then.

Closed by commit rP4ba4cb971178: Use "fa-shopping-bag" instead of "fa-list-alt" for Owners package icon (authored by epriestley, committed by epriestley). · Explain WhyMay 14 2016, 12:19 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10939: Support for OWNERS files.May 14 2016, 1:02 AM
epriestley mentioned this in T5000: Using Differential with plain Git, without requiring Arc.May 20 2016, 11:04 PM

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
phid/
2 lines

Diff 38329

View Options

src/applications/owners/phid/PhabricatorOwnersPackagePHIDType.php

Loading...
Phabricator · Built by Phacility