Page MenuHomePhabricator

Put "Push Policy" last in Diffusion, make editing Spaces work
ClosedPublic

Authored by epriestley on May 9 2016, 1:31 PM.
Tags
None
Referenced Files
F13239559: D15866.diff
Wed, May 22, 4:36 AM
F13233737: D15866.diff
Tue, May 21, 2:32 AM
F13212524: D15866.id38220.diff
Fri, May 17, 6:49 AM
F13211930: D15866.diff
Fri, May 17, 6:14 AM
F13196991: D15866.diff
Sun, May 12, 11:44 PM
F13191288: D15866.id38220.diff
Sat, May 11, 6:58 PM
F13180185: D15866.id38219.diff
Wed, May 8, 10:36 PM
Unknown Object (File)
Tue, May 7, 4:24 PM
Subscribers
None

Details

Summary

Ref T10923.

  • The "Policy" edit form currently goes "Push, View, Edit". Reorder the defaults to "View, Edit, Push".
  • Editing Spaces doesn't currently work: the element appears in the UI, but isn't actually processed when handling transactions. Make that work.
Test Plan
  • Edited a repository policies, saw "View, Edit, Push".
  • Moved a repository between Spaces.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Put "Push Policy" last in Diffusion, make editing Spaces work.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 9 2016, 1:33 PM
This revision was automatically updated to reflect the committed changes.