Page MenuHomePhabricator

Fix create links when no repositories exist
ClosedPublic

Authored by chad on May 5 2016, 3:56 AM.
Tags
None
Referenced Files
F13214672: D15849.diff
Fri, May 17, 12:19 PM
F13201382: D15849.id38179.diff
Tue, May 14, 11:42 AM
F13199822: D15849.id38180.diff
Mon, May 13, 6:51 PM
F13194575: D15849.diff
Sun, May 12, 9:40 PM
F13180192: D15849.id38179.diff
Wed, May 8, 10:37 PM
F13180191: D15849.id38178.diff
Wed, May 8, 10:36 PM
F13177347: D15849.diff
Wed, May 8, 7:38 PM
Unknown Object (File)
Mon, May 6, 11:05 PM

Details

Summary

Fixes T10925. Sends users to /new/ instead of /create/

Test Plan

Visit page, see links, clicky clicky.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Fix create links when no repositories exist.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
thoughtpolice added a reviewer: thoughtpolice.
thoughtpolice added a subscriber: thoughtpolice.

This doesn't quite fix it. /diffusion/new has this:

pasted_file (174×915 px, 32 KB)

But clicking on either of those just takes you back to /diffusion/create/ and /diffusion/import which bail out.

I actually have my own commit that fixes it (literally about to say arc diff when I saw this and tested it) but it just changes the path to /diffusion/edit/form/default/ which seems correct, as that is what the top-level Create Repository button on the right does.

This revision now requires changes to proceed.May 5 2016, 4:02 AM

literally, your patch is identical to mine, except those characters

spooky

chad edited edge metadata.
  • Remove /new/ as well
This revision is now accepted and ready to land.May 5 2016, 4:09 AM

This probably can be better from a blank state, but will wait until the dust settles. Thanks for catching the click through issue. I think /new/ gets nuked in all of this, but @epriestley can fix that in the am if not.

This revision was automatically updated to reflect the committed changes.

I'll note the /new/ stuff on T10923 -- it should be getting cleaned up, I just missed it in my cutover.