Page MenuHomePhabricator
Differential D15683

Rough cut at new "pro" Diffusion edit UI skeleton
ClosedPublic
Actions

Authored by epriestley on Apr 11 2016, 5:35 PM.
Tags
None
Referenced Files
F13279236: D15683.id37801.diff
Sat, Jun 1, 12:47 PM
F13277778: D15683.diff
Fri, May 31, 1:00 PM
F13267050: D15683.diff
Wed, May 29, 12:27 AM
F13263741: D15683.id37791.diff
Mon, May 27, 11:57 AM
F13233695: D15683.diff
Tue, May 21, 2:30 AM
F13188822: D15683.diff
Sat, May 11, 5:31 AM
F13175137: D15683.id37801.diff
Wed, May 8, 3:35 AM
Unknown Object (File)
Tue, May 7, 9:14 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T4292: Implement repository replication
Commits
rP8a153c1fe96f: Rough cut at new "pro" Diffusion edit UI skeleton
Summary

Ref T4292. This puts a very rough skeleton in place for the new "Manage Repository" UI, somewhat similar to the "Settings" UI.

Right now, it has one panel with no content, and is not reachable from the UI.

Test Plan

Screen Shot 2016-04-11 at 10.31.59 AM.png (1×1 px, 107 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37791.Apr 11 2016, 5:35 PM
epriestley retitled this revision from to Rough cut at new "pro" Diffusion edit UI skeleton.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4292: Implement repository replication.
epriestley updated this object.Apr 11 2016, 5:36 PM
chad accepted this revision.Apr 11 2016, 5:39 PM
chad edited edge metadata.

fyi, I do have a better design/layout for this in mind, should be easy to implement/retrofit.

src/applications/diffusion/management/DiffusionRepositoryClusterManagementPanel.php
14

seems like a magic number

This revision is now accepted and ready to land.Apr 11 2016, 5:39 PM
epriestley added inline comments.Apr 11 2016, 5:41 PM
src/applications/diffusion/management/DiffusionRepositoryClusterManagementPanel.php
14

don't worry I double-checked it

it's definitely magic

Closed by commit rP8a153c1fe96f: Rough cut at new "pro" Diffusion edit UI skeleton (authored by epriestley, committed by epriestley). · Explain WhyApr 12 2016, 12:37 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 13 2016, 3:33 AM

Revision Contents
Changeset List

Diff 37801

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryManageController.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryClusterManagementPanel.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryManagementPanel.php

Loading...
Phabricator · Built by Phacility