Paths

Table of Contentst

Differential D15551

Converting badge quality property from color to an integer representation for later sorting purposes
ClosedPublic
Actions

Authored by lpriestley on Mar 31 2016, 12:11 AM.

Tags

None

Referenced Files

	F13283223: D15551.diff
	Sun, Jun 2, 1:23 PM

	F13269067: D15551.diff
	Wed, May 29, 5:45 AM

	F13252314: D15551.diff
	Sat, May 25, 1:16 AM

	F13241541: D15551.diff
	Wed, May 22, 10:07 PM

	F13236094: D15551.id37494.diff
	Tue, May 21, 8:02 AM

	F13235278: D15551.id37493.diff
	Tue, May 21, 4:33 AM

	F13235277: D15551.id37492.diff
	Tue, May 21, 4:33 AM

	F13178469: D15551.diff
	Wed, May 8, 8:26 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9007: Allow Badges to be ordered by quality

Commits

rP00425cac94d5: Converting badge quality property from color to an integer representation for…

Summary

Test Plan

Create badges, update quality, search by quality without change of functionality.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 37492.Mar 31 2016, 12:11 AM

lpriestley retitled this revision from to Converting badge quality property from color to an integer representation for later sorting purposes.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T9007: Allow Badges to be ordered by quality.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 31 2016, 12:11 AM

Herald added a subscriber: Korvin. · View Herald Transcript

Some minor inline stuff but this looks broadly correct to me.

src/applications/badges/constants/PhabricatorBadgesQuality.php
16–18	Weird indent
21–25	Can this just be `return $quality`? Do we need this at all? I don't think anything calls it, and it can just be deleted.
src/applications/badges/editor/PhabricatorBadgesEditEngine.php
90–91	I think this should just be `$object->getQuality()` -- the map will be a map from `100 => "Uncommon"` but the "value" of a select control is the key (100), not the string ("Uncommon"). I would expect this to cause a bug here: Set a badge to a quality like "Legendary". Save it. Click "Edit Badge". The <select /> dropdown is now set to the wrong value (not "Legendary").
src/applications/badges/storage/PhabricatorBadgesBadge.php
27–28	Probably move this to `PhabricatorBadgesQuality`?

This revision is now accepted and ready to land.Mar 31 2016, 12:20 AM

Moving things around

Closed by commit rP00425cac94d5: Converting badge quality property from color to an integer representation for… (authored by lpriestley, committed by lpriestley). · Explain WhyMar 31 2016, 12:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20160330.badges.migratequality.sql

32 lines

20160330.badges.qualityxaction.mig.sql

59 lines

src/

__phutil_library_map__.php

2 lines

applications/

badges/

constants/

PhabricatorBadgesQuality.php

78 lines

controller/

PhabricatorBadgesViewController.php

5 lines

editor/

PhabricatorBadgesEditEngine.php

2 lines

PhabricatorBadgesEditor.php

3 lines

query/

PhabricatorBadgesSearchEngine.php

9 lines

storage/

PhabricatorBadgesBadge.php

25 lines

PhabricatorBadgesTransaction.php

5 lines

view/

phui/

PHUIBadgeMiniView.php

4 lines

PHUIBadgeView.php

43 lines

Diff 37494

resources/sql/autopatches/20160330.badges.migratequality.sql

Loading...

resources/sql/autopatches/20160330.badges.qualityxaction.mig.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/badges/constants/PhabricatorBadgesQuality.php

Loading...

src/applications/badges/controller/PhabricatorBadgesViewController.php

Loading...

src/applications/badges/editor/PhabricatorBadgesEditEngine.php

Loading...

src/applications/badges/editor/PhabricatorBadgesEditor.php

Loading...

src/applications/badges/query/PhabricatorBadgesSearchEngine.php

Loading...

src/applications/badges/storage/PhabricatorBadgesBadge.php

Loading...

src/applications/badges/storage/PhabricatorBadgesTransaction.php

Loading...

src/view/phui/PHUIBadgeMiniView.php

Loading...

src/view/phui/PHUIBadgeView.php

Loading...