Page MenuHomePhabricator
Differential D15380

Compress Harbormaster build logs inline
ClosedPublic
Actions

Authored by epriestley on Mar 1 2016, 10:21 PM.
Tags
None
Referenced Files
F13281019: D15380.diff
Sun, Jun 2, 9:37 AM
F13267913: D15380.diff
Wed, May 29, 4:23 AM
F13258046: D15380.id.diff
Sun, May 26, 6:20 AM
F13253382: D15380.diff
Sat, May 25, 2:37 AM
F13231931: D15380.diff
Tue, May 21, 12:53 AM
F13211188: D15380.id.diff
Fri, May 17, 5:33 AM
F13210831: D15380.diff
Fri, May 17, 5:15 AM
F13194756: D15380.diff
Sun, May 12, 9:51 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T5822: Implement garbage collection / automatic archiving for Harbormaster logs
Commits
Restricted Diffusion Commit
rP078bf59f59b0: Compress Harbormaster build logs inline
Summary

Ref T5822.

  • After a log is closed, compress it if possible.
  • Provide bin/harbormaster archive-logs to make it easier to change the storage format of logs.
Test Plan
  • Ran bin/harbormaster archive-logs on a bunch of logs, compressing and decompressing them without issues (same hashes, same decompressed size across multiple iterations).
  • Ran new builds, verified logs were compressed after they closed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37077.Mar 1 2016, 10:21 PM
epriestley retitled this revision from to Compress Harbormaster build logs inline.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T5822: Implement garbage collection / automatic archiving for Harbormaster logs.
chad accepted this revision.Mar 1 2016, 11:07 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2016, 11:07 PM
Closed by commit rP078bf59f59b0: Compress Harbormaster build logs inline (authored by epriestley, committed by epriestley). · Explain WhyMar 1 2016, 11:26 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T11402: Garbage collect and/or compress/archive harbormaster build unit messages.Aug 29 2016, 4:45 PM

Revision Contents
Changeset List

Diff 37082

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/management/HarbormasterManagementArchiveLogsWorkflow.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLogChunk.php

Loading...
View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLogChunkIterator.php

Loading...
Phabricator · Built by Phacility