Page MenuHomePhabricator
Differential D15305

Make repository callsigns optional
ClosedPublic
Actions

Authored by epriestley on Feb 18 2016, 2:20 PM.
Tags
None
Referenced Files
F13274509: D15305.diff
Fri, May 31, 3:47 AM
F13262957: D15305.id36924.diff
Mon, May 27, 5:21 AM
F13260558: D15305.diff
Mon, May 27, 12:04 AM
F13249628: D15305.id.diff
Fri, May 24, 9:52 AM
F13244779: D15305.diff
Thu, May 23, 5:18 AM
F13241634: D15305.diff
Wed, May 22, 11:02 PM
F13238913: D15305.id36914.diff
Tue, May 21, 10:38 PM
Unknown Object (File)
Tue, May 7, 6:09 AM
View All Files
Subscribers
avivey
Tokens
"Mountain of Wealth" token, awarded by techdragon.

Details

Reviewers
chad
Maniphest Tasks
T4245: Make repository URIs slightly prettier
Commits
Restricted Diffusion Commit
rPdc7d0b4a56d8: Make repository callsigns optional
Summary

Ref T4245. This could still use a little UI smoothing, but:

  • Don't require a callsign on the create flow (you can add one later in "Edit Basic Information" if you want).
  • Allow existing callsigns to be removed.
Test Plan
  • Created a new repository with no callsign.
  • Cloned it; pushed to it.
  • Browsed around Diffusion a bunch.
  • Visited a commit URI.
  • Added a callsign to it.
  • Removed the callsign again.
  • Referenced it with R22 in remarkup.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36914.Feb 18 2016, 2:20 PM
epriestley updated this revision to Diff 36915.
epriestley retitled this revision from to Make repository callsigns optional.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T4245: Make repository URIs slightly prettier.
  • Fix one issue with {abcdef} on a hash in a callsign-free repository.
chad accepted this revision.Feb 18 2016, 4:20 PM
chad edited edge metadata.

This could still use a little UI smoothing

imgres.jpg (225×225 px, 8 KB)

This revision is now accepted and ready to land.Feb 18 2016, 4:20 PM
Closed by commit rPdc7d0b4a56d8: Make repository callsigns optional (authored by epriestley, committed by epriestley). · Explain WhyFeb 18 2016, 6:36 PM
This revision was automatically updated to reflect the committed changes.
avivey added a subscriber: avivey.Feb 18 2016, 6:48 PM

doctordance

• Persona added a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 11:16 AM
tycho.tatitscheff removed a child revision: D15341: Fix Ponder Exception, spacing.Feb 24 2016, 12:31 PM
techdragon awarded a token.Feb 27 2016, 11:38 AM
epriestley mentioned this in T4245: Make repository URIs slightly prettier.May 12 2016, 1:11 AM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
4 lines
src/
applications/
diffusion/
controller/
61 lines
7 lines
repository/
storage/
41 lines

Diff 36924

View Options

resources/sql/autopatches/20160218.callsigns.1.sql

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryCreateController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility