Page MenuHomePhabricator

Support ID-based repository URIs, and canonicalize repository URIs
ClosedPublic

Authored by epriestley on Feb 18 2016, 12:22 PM.
Tags
None
Referenced Files
F13249036: D15301.id.diff
Fri, May 24, 6:08 AM
F13231272: D15301.id36910.diff
Tue, May 21, 12:20 AM
F13230885: D15301.id36920.diff
Mon, May 20, 11:23 PM
F13201960: D15301.id36908.diff
Tue, May 14, 7:00 PM
F13179376: D15301.diff
Wed, May 8, 9:09 PM
Unknown Object (File)
Sat, May 4, 6:42 PM
Unknown Object (File)
Apr 30 2024, 11:26 PM
Unknown Object (File)
Apr 29 2024, 3:32 AM
Subscribers
None

Details

Summary

Ref T4245. Make /diffusion/123/ work, but redirect the user to /diffusion/XYZ/ if the repository has a callsign.

(Right now, every repository has a callsign, so this always redirects.)

Also redirect /R123:abcdef if the repository has a callsign.

Also also, move the Pull garbage collector somewhere more sensible.

Test Plan
  • Added test coverage.
  • Visited /diffusion/1/, was redirected.
  • Visited /diffusion/R1:abcdef, was redirected.
  • Browsed Diffusion normally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Support ID-based repository URIs, and canonicalize repository URIs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Fix bad regex for repositories with multiple-digit IDs, like "18".
  • Also fix the other copy of the dodgy regexp.
This revision is now accepted and ready to land.Feb 18 2016, 4:14 PM
This revision was automatically updated to reflect the committed changes.