Page MenuHomePhabricator
Differential D15133

Allow objects implementing `ArrayAccess` to the passed to `idx`
AbandonedPublic
Actions

Authored by joshuaspence on Jan 28 2016, 11:32 PM.
Tags
None
Referenced Files
F13186013: D15133.diff
Sat, May 11, 3:22 AM
F13180786: D15133.id.diff
Thu, May 9, 3:59 AM
F13175430: D15133.id36537.diff
Wed, May 8, 5:10 AM
Unknown Object (File)
Tue, May 7, 6:07 AM
Unknown Object (File)
Fri, May 3, 3:44 AM
Unknown Object (File)
Thu, May 2, 9:43 PM
Unknown Object (File)
Thu, May 2, 5:31 AM
Unknown Object (File)
Mon, Apr 29, 3:46 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

This allows idx to work with CaseInsensitiveArray, for example.

Test Plan

Added a test case.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/utils/utils.php:1194XHP45PHP Compatibility
Errorsrc/utils/utils.php:1194XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 10376
Build 12659: Run Core Tests
Build 12658: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 36537.Jan 28 2016, 11:32 PM
joshuaspence retitled this revision from to Allow objects implementing `ArrayAccess` to the passed to `idx`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 28 2016, 11:32 PM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley mentioned this in T11493: Unable to view Harbormaster Build Plans after tagging many projects on a build plan.Aug 19 2016, 5:36 PM
joshuaspence abandoned this revision.May 17 2019, 1:52 AM

Not actively working on this.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
utils/
__tests__/
3 lines99%
Loading...
9 lines71%
Loading...

Diff 36537

View Options

src/utils/__tests__/PhutilUtilsTestCase.php

Loading...
View Options

src/utils/utils.php

Loading...
Phabricator · Built by Phacility