Page MenuHomePhabricator
Differential D14880

Keep hovercards on screen a little harder
ClosedPublic
Actions

Authored by epriestley on Dec 24 2015, 8:34 PM.
Tags
None
Referenced Files
F13268029: D14880.diff
Wed, May 29, 4:32 AM
F13253509: D14880.diff
Sat, May 25, 2:43 AM
F13240265: D14880.id35969.diff
Wed, May 22, 12:27 PM
F13231602: D14880.diff
Tue, May 21, 12:36 AM
F13215576: D14880.id35969.diff
Fri, May 17, 6:20 PM
F13211005: D14880.id35970.diff
Fri, May 17, 5:24 AM
F13186060: D14880.diff
Sat, May 11, 3:24 AM
Unknown Object (File)
Tue, May 7, 6:09 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8980: Make hovecards activate for standard handle lists
Commits
Restricted Diffusion Commit
rP8025bc6432e2: Keep hovercards on screen a little harder
Summary

Ref T8980. This calculation was not quite right and you could sneak one off screen if you tried carefully.

Test Plan

Couldn't sneak one off screen anymore.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35969.Dec 24 2015, 8:34 PM
epriestley retitled this revision from to Keep hovercards on screen a little harder.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8980: Make hovecards activate for standard handle lists.
chad accepted this revision.Dec 24 2015, 8:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 8:35 PM
Closed by commit rP8025bc6432e2: Keep hovercards on screen a little harder (authored by epriestley, committed by epriestley). · Explain WhyDec 24 2015, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
20 lines
src/
applications/
maniphest/
controller/
5 lines
webroot/
rsrc/
js/
core/
2 lines

Diff 35970

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

webroot/rsrc/js/core/Hovercard.js

Loading...
Phabricator · Built by Phacility