Page MenuHomePhabricator
Differential D14877

Show hovercards for most links in object property views
ClosedPublic
Actions

Authored by epriestley on Dec 24 2015, 6:47 PM.
Tags
None
Referenced Files
F13281965: D14877.diff
Sun, Jun 2, 11:32 AM
F13265984: D14877.id35961.diff
Tue, May 28, 7:57 AM
F13225656: D14877.id35966.diff
Sun, May 19, 4:32 PM
F13192625: D14877.id35961.diff
Sun, May 12, 9:04 AM
F13187278: D14877.diff
Sat, May 11, 4:26 AM
F13180660: D14877.id.diff
Thu, May 9, 2:10 AM
Unknown Object (File)
Tue, May 7, 7:33 AM
Unknown Object (File)
May 3 2024, 6:51 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8980: Make hovecards activate for standard handle lists
Commits
Restricted Diffusion Commit
rP3ec07c498769: Show hovercards for most links in object property views
Summary

Ref T8980. This isn't 100% coverage but should be pretty much all of the common ones.

These feel a touch iffy to me at first glance so I didn't go crazy trying to hunt all of them down. I have some other plans for them so maybe they'll feel better by the end of it.

Test Plan

Hovered over author, reviewers, blocked tasks, projects, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35961.Dec 24 2015, 6:47 PM
epriestley retitled this revision from to Show hovercards for most links in object property views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8980: Make hovecards activate for standard handle lists.
chad accepted this revision.Dec 24 2015, 7:27 PM
chad edited edge metadata.

If you're in a javascript-y mood, maybe we can fix them from rendering outside of the screen?

This revision is now accepted and ready to land.Dec 24 2015, 7:27 PM
epriestley added a comment.Dec 24 2015, 7:38 PM

woah woah that's a big part of the charm!

chad added a comment.Dec 24 2015, 7:39 PM

1313294644198.jpg (288×432 px, 37 KB)

chad added a comment.Dec 24 2015, 7:40 PM

images.png (177×284 px, 4 KB)

chad added a comment.Dec 24 2015, 7:40 PM

b62.png (270×359 px, 47 KB)

chad added a comment.Dec 24 2015, 7:41 PM

Funny-facepalm-meme-computer.jpg (167×441 px, 13 KB)

Closed by commit rP3ec07c498769: Show hovercards for most links in object property views (authored by epriestley, committed by epriestley). · Explain WhyDec 24 2015, 8:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
customfield/
2 lines
view/
2 lines
maniphest/
controller/
23 lines
phid/
31 lines
view/
9 lines
9 lines
33 lines
project/
events/
3 lines
subscriptions/
view/
2 lines
infrastructure/
customfield/
standard/
2 lines

Diff 35966

View Options

src/applications/differential/customfield/DifferentialAuthorField.php

Loading...
View Options

src/applications/differential/view/DifferentialReviewersView.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/phid/PhabricatorObjectHandle.php

Loading...
View Options

src/applications/phid/view/PHUIHandleListView.php

Loading...
View Options

src/applications/phid/view/PHUIHandleTagListView.php

Loading...
View Options

src/applications/phid/view/PHUIHandleView.php

Loading...
View Options

src/applications/project/events/PhabricatorProjectUIEventListener.php

Loading...
View Options

src/applications/subscriptions/view/SubscriptionListStringBuilder.php

Loading...
View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Loading...
Phabricator · Built by Phacility