Page MenuHomePhabricator

Prevent "Spaces" field from being set to inconsistent values
ClosedPublic

Authored by epriestley on Dec 17 2015, 7:02 PM.
Tags
None
Referenced Files
F13277577: D14812.diff
Fri, May 31, 11:47 AM
F13270822: D14812.id35808.diff
Wed, May 29, 12:14 PM
F13262781: D14812.id35809.diff
Mon, May 27, 3:42 AM
F13248510: D14812.id35809.diff
Fri, May 24, 3:00 AM
F13248507: D14812.id35808.diff
Fri, May 24, 2:59 AM
F13248505: D14812.id.diff
Fri, May 24, 2:58 AM
F13248504: D14812.diff
Fri, May 24, 2:58 AM
F13235013: D14812.diff
Tue, May 21, 4:11 AM
Subscribers
None

Details

Summary

At least for now, the "Space" field is just a subfield of the "Visible To" field, so:

  • it doesn't get any separate settings; and
  • it always uses the "Visible To" settings.
Test Plan
  • Created a form with a hidden view policy field.
  • Created stuff with no "you must pick a space" errors.
  • Created stuff with a normal form.
  • Prefilled "Space" on a noraml form.
  • Verified that trying to prefill "Space" on a form with "Visible To" hidden does nothing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable