Page MenuHomePhabricator
Differential D13759

Remove extra `/phurl` in request url
AbandonedPublic
Actions

Authored by ox on Jul 30 2015, 12:15 AM.
Tags
None
Referenced Files
F13292243: D13759.id.diff
Wed, Jun 5, 3:05 AM
F13292242: D13759.diff
Wed, Jun 5, 3:05 AM
F13241830: D13759.id33232.diff
Wed, May 22, 11:52 PM
F13218427: D13759.id33233.diff
Sat, May 18, 12:35 PM
F13217185: D13759.id.diff
Sat, May 18, 3:48 AM
F13192654: D13759.diff
Sun, May 12, 9:12 AM
F13188002: D13759.diff
Sat, May 11, 4:54 AM
Unknown Object (File)
May 7 2024, 4:04 AM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9009: Cannot comment on Phurl links
Summary

Should fix T9009

Test Plan

I cannot get Phabricator to run on my dev machine (OS X), but this should be correct.

Diff Detail

Repository
rP Phabricator
Branch
arcpatch-D13759
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 7449
Build 7938: [Placeholder Plan] Wait for 30 Seconds
Build 7937: arc lint + arc unit

Event Timeline

ox updated this revision to Diff 33232.Jul 30 2015, 12:15 AM
ox retitled this revision from to Remove extra `/phurl` in request url.
ox updated this object.
ox edited the test plan for this revision. (Show Details)
ox added a task: T9009: Cannot comment on Phurl links.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 30 2015, 12:15 AM
Herald added a subscriber: epriestley. · View Herald Transcript
chad added a subscriber: chad.Jul 30 2015, 12:26 AM
chad added inline comments.
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
48

I think you don't need the first / either

ox updated this revision to Diff 33233.Jul 30 2015, 3:16 AM
ox marked an inline comment as done.
ox edited edge metadata.

remove leading / as it was getting trimmed anyway

chad accepted this revision.Jul 30 2015, 3:18 AM
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jul 30 2015, 3:18 AM
chad added a comment.EditedJul 30 2015, 3:21 AM

Although, looking at the code, PhabricatorPhurlCommentController doesn't exist either, nor the route.

But this change is correct!

chad mentioned this in T9009: Cannot comment on Phurl links.Jul 30 2015, 3:40 AM
ox added a comment.Jul 30 2015, 2:07 PM

I don't know enough PHP to really get what this app is doing, but I imagined some smart folks at Phacility had created a generic commenting service and I was just not seeing it. Thanks for the help!

epriestley requested changes to this revision.Jul 30 2015, 2:11 PM
epriestley added a reviewer: epriestley.

I cannot get Phabricator to run on my dev machine (OS X), but this should be correct.

Let's just wait for the normal dev process here.

This revision now requires changes to proceed.Jul 30 2015, 2:11 PM
ox abandoned this revision.Aug 3 2015, 6:28 PM

Revision Contents
Changeset List

PathSize
src/
applications/
phurl/
controller/
2 lines

Diff 33233

View Options

src/applications/phurl/controller/PhabricatorPhurlURLViewController.php

Loading...
Phabricator · Built by Phacility