Page MenuHomePhabricator
Differential D13545

When an install has spaces but a user has no access, roadblock them
ClosedPublic
Actions

Authored by epriestley on Jul 3 2015, 5:44 PM.
Tags
None
Referenced Files
F13292617: D13545.diff
Wed, Jun 5, 4:35 AM
F13265126: D13545.diff
Tue, May 28, 1:25 AM
F13264227: D13545.id32731.diff
Mon, May 27, 3:17 PM
F13264033: D13545.id.diff
Mon, May 27, 1:55 PM
F13248782: D13545.diff
Fri, May 24, 4:07 AM
F13237791: D13545.id32731.diff
Tue, May 21, 2:57 PM
F13227903: D13545.diff
Mon, May 20, 5:27 AM
F13226588: D13545.diff
Sun, May 19, 9:43 PM
View All Files
Subscribers
eadler
epriestley

Details

Reviewers
btrahan
eadler
Maniphest Tasks
T8449: Spaces v1 Errata
Commits
Restricted Diffusion Commit
rPbc22413fa7dd: When an install has spaces but a user has no access, roadblock them
Summary

Ref T8449. If a user doesn't have access to any spaces, most applications just don't work, and they fail in confusing ways.

Just lock users out of everything explicitly up front with a clear message instead of letting them stumble into a big broken mess.

Test Plan

Locked a user out of all spaces, saw error to that effect.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32727.Jul 3 2015, 5:44 PM
epriestley retitled this revision from to When an install has spaces but a user has no access, roadblock them.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8449: Spaces v1 Errata.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 3 2015, 5:44 PM
eadler accepted this revision.Jul 3 2015, 7:43 PM
eadler added a reviewer: eadler.
eadler added a subscriber: eadler.
eadler added inline comments.
src/applications/spaces/controller/PhabricatorSpacesNoAccessController.php
12–13

this text might be a bit confusing to a new user (whom I'd expect to be most likely not to have any access to spaces) but is technically accurate.

This revision is now accepted and ready to land.Jul 3 2015, 7:43 PM
Closed by commit rPbc22413fa7dd: When an install has spaces but a user has no access, roadblock them (authored by epriestley, committed by epriestley). · Explain WhyJul 3 2015, 8:03 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D13723: Countdown mail support part.Jul 27 2015, 2:33 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
base/
controller/
17 lines
spaces/
controller/
20 lines

Diff 32731

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/spaces/controller/PhabricatorSpacesNoAccessController.php

Loading...
Phabricator · Built by Phacility