Page MenuHomePhabricator
Differential D13481

Commenting on instances of a recurring event should create a new event with its own comments
ClosedPublic
Actions

Authored by lpriestley on Jun 29 2015, 10:41 PM.
Tags
None
Referenced Files
F13269810: D13481.id.diff
Wed, May 29, 7:43 AM
F13268050: D13481.diff
Wed, May 29, 4:33 AM
F13253532: D13481.diff
Sat, May 25, 2:44 AM
F13230969: D13481.diff
Mon, May 20, 11:28 PM
F13228617: D13481.id32619.diff
Mon, May 20, 10:45 AM
F13225201: D13481.id32639.diff
Sun, May 19, 1:58 PM
F13209518: D13481.id32638.diff
Fri, May 17, 12:42 AM
F13186409: D13481.id32639.diff
Sat, May 11, 3:36 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8696: User comments in recurring events should be added per instance
Commits
Restricted Diffusion Commit
rP28e0af5a62c8: Commenting on instances of a recurring event should create a new event with…
Summary

Closes T8696, Commenting on instances of a recurring event should create a new event with its own comments

Test Plan

Open recurring event instance (not exception), should see no timeline, leave a comment, an exception to event should be created.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 32619.Jun 29 2015, 10:41 PM
lpriestley retitled this revision from to Commenting on instances of a recurring event should create a new event with its own comments.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8696: User comments in recurring events should be added per instance.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 29 2015, 10:41 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley accepted this revision.Jun 29 2015, 10:51 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
97

Sometimes no $sequence in this

This revision is now accepted and ready to land.Jun 29 2015, 10:51 PM
lpriestley updated this revision to Diff 32638.Jun 30 2015, 6:47 PM
lpriestley edited edge metadata.

$sequence only when it exists

Closed by commit rP28e0af5a62c8: Commenting on instances of a recurring event should create a new event with… (authored by lpriestley, committed by lpriestley). · Explain WhyJun 30 2015, 6:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32639

View Options

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventCommentController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
Phabricator · Built by Phacility