Differential D13384

Move Passphrase to SearchField
ClosedPublic
Actions

Authored by epriestley on Jun 22 2015, 2:27 AM.

Tags

None

Referenced Files

	F13241890: D13384.id32404.diff
	Thu, May 23, 12:05 AM

	F13240055: D13384.id32404.diff
	Wed, May 22, 9:53 AM

	F13224022: D13384.id32415.diff
	Sun, May 19, 5:57 AM

	F13209523: D13384.id32404.diff
	Fri, May 17, 12:44 AM

	F13196549: D13384.diff
	Sun, May 12, 11:21 PM

	F13191629: D13384.id32404.diff
	Sat, May 11, 11:04 PM

	F13183774: D13384.id32415.diff
	Fri, May 10, 12:18 PM

	Unknown Object (File)
	Mon, May 6, 12:48 AM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rPbc6d0478b4d3: Move Passphrase to SearchField

Summary

Prepares for bringing spaces and a new object policy here.

Test Plan

Used all search controls dozens of times.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32404.Jun 22 2015, 2:27 AM

epriestley retitled this revision from to Move Passphrase to SearchField.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 22 2015, 2:27 AM

btrahan accepted this revision.Jun 22 2015, 5:19 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/passphrase/query/PassphraseCredentialQuery.php
143	just double checking intentional

This revision is now accepted and ready to land.Jun 22 2015, 5:19 PM

epriestley added inline comments.Jun 22 2015, 5:26 PM

src/applications/passphrase/query/PassphraseCredentialQuery.php
143	Yeah, just smoothing out searching for "Twitter" to match "twitter", which doesn't work without this. This isn't really ideal but is a quick hack to improve behavior without any real negative effects AFAIK.

Closed by commit rPbc6d0478b4d3: Move Passphrase to SearchField (authored by epriestley, committed by epriestley). · Explain WhyJun 22 2015, 6:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

passphrase/

query/

PassphraseCredentialQuery.php

51 lines

PassphraseCredentialSearchEngine.php

63 lines

Diff 32415

src/applications/passphrase/query/PassphraseCredentialQuery.php

Loading...

src/applications/passphrase/query/PassphraseCredentialSearchEngine.php

Loading...