Page MenuHomePhabricator
Differential D13175

Convert Files to SearchFields
ClosedPublic
Actions

Authored by epriestley on Jun 5 2015, 10:40 PM.
Tags
None
Referenced Files
F13213215: D13175.diff
Fri, May 17, 7:31 AM
F13206764: D13175.id31851.diff
Wed, May 15, 5:27 PM
F13206763: D13175.id31877.diff
Wed, May 15, 5:27 PM
F13206738: D13175.id.diff
Wed, May 15, 5:14 PM
F13206570: D13175.id31877.diff
Wed, May 15, 12:10 PM
F13180979: D13175.diff
Thu, May 9, 6:52 AM
F13176101: D13175.id.diff
Wed, May 8, 10:27 AM
Unknown Object (File)
Tue, May 7, 5:34 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch
T8441: Integrate Spaces into ApplicationSearch
Commits
Restricted Diffusion Commit
rPcdef3e8bc868: Convert Files to SearchFields
Summary

Ref T8441. Ref T7715.

  • Update FileSearchEngine.
  • Nothing too special/fancy.
Test Plan
  • Searched for various files.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31851.Jun 5 2015, 10:40 PM
epriestley retitled this revision from to Convert Files to SearchFields.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T8441: Integrate Spaces into ApplicationSearch, T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 5 2015, 10:40 PM
btrahan accepted this revision.Jun 6 2015, 7:58 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2015, 7:58 PM
Closed by commit rPcdef3e8bc868: Convert Files to SearchFields (authored by epriestley, committed by epriestley). · Explain WhyJun 7 2015, 2:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
files/
query/
61 lines
86 lines
search/
field/
48 lines

Diff 31877

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/query/PhabricatorFileQuery.php

Loading...
View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...
View Options

src/applications/search/field/PhabricatorSearchThreeStateField.php

Loading...
Phabricator · Built by Phacility