Page MenuHomePhabricator

Introduce a request cache mechanism
ClosedPublic

Authored by epriestley on Jun 4 2015, 7:19 PM.
Tags
None
Referenced Files
F13259243: D13153.id.diff
Sun, May 26, 6:20 PM
F13247996: D13153.id31804.diff
Fri, May 24, 12:09 AM
F13244199: D13153.diff
Thu, May 23, 4:36 AM
F13236609: D13153.id31804.diff
Tue, May 21, 10:14 AM
F13236584: D13153.id31791.diff
Tue, May 21, 10:13 AM
F13236583: D13153.id.diff
Tue, May 21, 10:13 AM
F13200687: D13153.diff
Tue, May 14, 2:30 AM
F13194321: D13153.diff
Sun, May 12, 9:29 PM
Subscribers

Details

Summary

Ref T8424. This adds a standard KeyValueCache to serve as a request cache.

In particular, I need to cache Spaces (they are frequently accessed, sometimes by multiple viewers) but not have them survive longer than the scope of one request.

This request cache is explicitly destroyed by each web request and each daemon request.

In the very long term, building this kind of construct supports reusing PHP interpreters to run web requests (see some discussion in T2312).

Test Plan
  • Added and executed unit tests.
  • Ran every daemon.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable