Page MenuHomePhabricator

Remove PhabricatorStartup::getGlobal/setGlobal mechanism
ClosedPublic

Authored by epriestley on Jun 4 2015, 6:59 PM.
Tags
None
Referenced Files
F13207759: D13152.id31790.diff
Thu, May 16, 3:47 AM
F13203398: D13152.diff
Tue, May 14, 11:42 PM
F13200639: D13152.diff
Tue, May 14, 2:16 AM
F13185770: D13152.diff
Sat, May 11, 3:12 AM
Unknown Object (File)
Tue, May 7, 5:40 AM
Unknown Object (File)
Fri, May 3, 3:26 AM
Unknown Object (File)
Mon, Apr 29, 2:58 PM
Unknown Object (File)
Mon, Apr 29, 2:49 PM
Subscribers

Details

Summary

Ref T8424. Fixes T7114. This was envisioned as a per-request cache for reusing interpreters, but isn't a good fit for that in modern Phabricator.

In particular, it isn't loaded by the daemons, but they have equal need for per-request caching.

Since I finally need such a cache for Spaces, throw the old stuff away before I built a more modern cache.

Also resolves T7114 by dropping filtering on $_SERVER. I'm pretty sure this is the simplest fix, see D12977 for a bit more discussion.

Test Plan

Called didFatal() from somewhere in normal code and verified it was able to use the access log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove PhabricatorStartup::getGlobal/setGlobal mechanism.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 4 2015, 9:15 PM
This revision was automatically updated to reflect the committed changes.