Page MenuHomePhabricator
Differential D13102

Implement DestructibleInterface on Spaces, add some basic tests
ClosedPublic
Actions

Authored by epriestley on Jun 1 2015, 6:54 PM.
Tags
None
Referenced Files
F13273070: D13102.diff
Fri, May 31, 1:32 AM
F13230776: D13102.diff
Mon, May 20, 11:19 PM
F13229255: D13102.id31631.diff
Mon, May 20, 3:11 PM
F13214894: D13102.id31631.diff
Fri, May 17, 1:38 PM
F13213151: D13102.diff
Fri, May 17, 7:27 AM
Unknown Object (File)
Tue, May 7, 5:17 AM
Unknown Object (File)
May 3 2024, 7:12 AM
Unknown Object (File)
May 3 2024, 2:38 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8377: Build the core "Spaces" Application
Commits
Restricted Diffusion Commit
rP76523eec6718: Implement DestructibleInterface on Spaces, add some basic tests
Summary

Ref T8377. Mostly just a framework for test coverage.

Test Plan

Tests pass.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31631.Jun 1 2015, 6:54 PM
epriestley retitled this revision from to Implement DestructibleInterface on Spaces, add some basic tests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8377: Build the core "Spaces" Application.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 1 2015, 6:54 PM
btrahan accepted this revision.Jun 1 2015, 6:55 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/spaces/__tests__/PhabricatorSpacesTestCase.php
96–97

policy transactions not ready yet? or maybe this is necessary to make sure tests always work regardess of app settings?

This revision is now accepted and ready to land.Jun 1 2015, 6:55 PM
epriestley added inline comments.Jun 1 2015, 7:00 PM
src/applications/spaces/__tests__/PhabricatorSpacesTestCase.php
96–97

Oh, right. I added these for the latter case while doing something else but should be able to just use transactions.

epriestley updated this revision to Diff 31632.Jun 1 2015, 7:02 PM
epriestley edited edge metadata.
  • Use policy transactions.
Closed by commit rP76523eec6718: Implement DestructibleInterface on Spaces, add some basic tests (authored by epriestley, committed by epriestley). · Explain WhyJun 1 2015, 7:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
applications/
spaces/
__tests__/
135 lines
storage/
12 lines
transactions/
editor/
7 lines

Diff 31633

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/spaces/__tests__/PhabricatorSpacesTestCase.php

Loading...
View Options

src/applications/spaces/storage/PhabricatorSpacesNamespace.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility