Page MenuHomePhabricator

Add "request time" event and viewer and context data to Multimeter
ClosedPublic

Authored by epriestley on Apr 30 2015, 7:30 PM.
Tags
None
Referenced Files
F13271820: D12630.diff
Thu, May 30, 5:56 AM
F13223666: D12630.diff
Sun, May 19, 4:46 AM
F13215587: D12630.id.diff
Fri, May 17, 6:24 PM
F13206555: D12630.diff
Wed, May 15, 11:50 AM
F13205683: D12630.diff
Wed, May 15, 2:17 AM
F13189688: D12630.diff
Sat, May 11, 6:17 AM
F13184169: D12630.id30323.diff
Fri, May 10, 4:06 PM
Unknown Object (File)
Tue, May 7, 10:03 AM
Subscribers

Details

Summary

Ref T6930. Only notable thing here is that I prevented non-admins from slicing down by viewing user, since it feels a little creepy to go see what pages you looked at, even though we only show which controllers you invoked. However, it feels important enough to be able to see users destorying the server with crazy requests to let admins see this data.

Test Plan

Screen Shot 2015-04-30 at 12.25.16 PM.png (1×1 px, 390 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Add "request time" event and viewer and context data to Multimeter.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 1 2015, 7:10 PM
This revision was automatically updated to reflect the committed changes.