Page MenuHomePhabricator
Differential D12470

Collapse "Show unassigned tasks" in Maniphest into a parameterized owners typeahead
ClosedPublic
Actions

Authored by epriestley on Apr 19 2015, 3:36 PM.
Tags
None
Referenced Files
F13192006: D12470.id29925.diff
Sun, May 12, 3:50 AM
F13188151: D12470.diff
Sat, May 11, 5:04 AM
Unknown Object (File)
Tue, May 7, 8:16 AM
Unknown Object (File)
Mon, May 6, 11:52 PM
Unknown Object (File)
Mon, May 6, 1:34 AM
Unknown Object (File)
Sun, May 5, 4:19 PM
Unknown Object (File)
Fri, May 3, 8:00 AM
Unknown Object (File)
Mon, Apr 29, 2:53 AM
View All Files
Subscribers
epriestley
Tokens
"Doubloon" token, awarded by chad.

Details

Reviewers
btrahan
Maniphest Tasks
T4100: Support query parameterization in typeaheads
Commits
Restricted Diffusion Commit
rP6fa9b10914e6: Collapse "Show unassigned tasks" in Maniphest into a parameterized owners…
Summary

Ref T4100. Support viewer(), members(), and add a new none().

Test Plan
  • Used all new functions.
  • Batch edited tasks with unassign action.
  • Saved a query from master, upgrade it to this patch, checkbox migrated cleanly into a "no one" token.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29925.Apr 19 2015, 3:36 PM
epriestley retitled this revision from to Collapse "Show unassigned tasks" in Maniphest into a parameterized owners typeahead.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4100: Support query parameterization in typeaheads.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 19 2015, 3:36 PM
chad awarded a token.Apr 20 2015, 5:27 AM
btrahan accepted this revision.Apr 20 2015, 4:52 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 4:52 PM
Closed by commit rP6fa9b10914e6: Collapse "Show unassigned tasks" in Maniphest into a parameterized owners… (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
10 lines
applications/
maniphest/
constants/
1 line
controller/
5 lines
query/
4 lines
43 lines
typeahead/
64 lines
maniphest/
typeahead/
typeahead/
datasource/
ManiphestAssigneeDatasource.php
PhabricatorTypeaheadOwnerDatasource.php
8 lines
ManiphestOwnerDatasource.php
PhabricatorTypeaheadOwnerDatasource.php
8 lines
search/
query/
2 lines
typeahead/
controller/
3 lines
datasource/

Diff 29961

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/maniphest/constants/ManiphestTaskOwner.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestBatchEditController.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...
View Options

src/applications/maniphest/typeahead/ManiphestAssigneeDatasource.php

Loading...
View Options

src/applications/maniphest/typeahead/ManiphestNoOwnerDatasource.php

Loading...
View Options

src/applications/maniphest/typeahead/ManiphestOwnerDatasource.php

Loading...
View Options

src/applications/search/query/PhabricatorSearchApplicationSearchEngine.php

Loading...
View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadNoOwnerDatasource.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadOwnerDatasource.php

Loading...
Phabricator · Built by Phacility