Page MenuHomePhabricator

Prepare a replacement for Controller->renderHandlesForPHIDs()
ClosedPublic

Authored by epriestley on Mar 30 2015, 1:24 PM.
Tags
None
Referenced Files
F13187343: D12205.diff
Sat, May 11, 4:28 AM
F13174970: D12205.diff
Wed, May 8, 2:18 AM
Unknown Object (File)
Tue, May 7, 9:49 AM
Unknown Object (File)
Tue, May 7, 7:35 AM
Unknown Object (File)
Fri, May 3, 6:57 AM
Unknown Object (File)
Tue, Apr 30, 12:33 PM
Unknown Object (File)
Thu, Apr 25, 1:21 AM
Unknown Object (File)
Fri, Apr 19, 8:07 PM
Subscribers

Details

Summary

Ref T7689. This gives HandleLists renderList() and renderHandle() methods, which return views that can perform just-in-time data fetching and generally look and feel like other rendering code, instead of being odd pseudo-functional methods on Controller.

Also converts callsites on the Maniphest detail page to use these methods.

Next changes will wipe out more of the callsites.

Test Plan
  • Viewed Maniphest detail page with many relevant handles.
  • Created a new subtask.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prepare a replacement for Controller->renderHandlesForPHIDs().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 8:01 PM
This revision was automatically updated to reflect the committed changes.