Page MenuHomePhabricator
Differential D12204

Remove Controller->getLoadedHandles()
ClosedPublic
Actions

Authored by epriestley on Mar 30 2015, 12:51 PM.
Tags
None
Referenced Files
F13195030: D12204.diff
Sun, May 12, 10:04 PM
F13177793: D12204.diff
Wed, May 8, 7:57 PM
F13173757: D12204.id.diff
Tue, May 7, 8:53 PM
Unknown Object (File)
Tue, May 7, 12:03 PM
Unknown Object (File)
Sun, May 5, 1:17 AM
Unknown Object (File)
Fri, May 3, 3:09 PM
Unknown Object (File)
Thu, May 2, 12:30 AM
Unknown Object (File)
Thu, Apr 25, 2:32 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7689: Load handles just-in-time
Commits
Restricted Diffusion Commit
rP580590fcc9fd: Remove Controller->getLoadedHandles()
Summary

Ref T7689. Removes this part of the Controller->loadHandles() + Controller->getLoadedHandles() mechanism.

Test Plan
  • Viewed Herald transcripts.
  • Viewed Maniphest tasks with attached revisions and commits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29327.Mar 30 2015, 12:51 PM
epriestley retitled this revision from to Remove Controller->getLoadedHandles().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7689: Load handles just-in-time.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 30 2015, 12:51 PM
btrahan accepted this revision.Mar 30 2015, 7:57 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 7:57 PM
Closed by commit rP580590fcc9fd: Remove Controller->getLoadedHandles() (authored by epriestley, committed by epriestley). · Explain WhyMar 31 2015, 12:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
base/
controller/
6 lines
herald/
adapter/
17 lines
controller/
6 lines
maniphest/
controller/
21 lines
phid/
handle/
pool/
14 lines

Diff 29353

View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/phid/handle/pool/PhabricatorHandleList.php

Loading...
Phabricator · Built by Phacility