Page MenuHomePhabricator

Enable the chunk storage engine
ClosedPublic

Authored by epriestley on Mar 14 2015, 4:23 PM.
Tags
None
Referenced Files
F13281008: D12079.diff
Sun, Jun 2, 9:34 AM
F13267987: D12079.diff
Wed, May 29, 4:29 AM
F13264985: D12079.diff
Tue, May 28, 12:19 AM
F13251863: D12079.diff
Sat, May 25, 12:49 AM
F13226585: D12079.id29061.diff
Sun, May 19, 9:43 PM
Unknown Object (File)
Tue, May 7, 2:55 AM
Unknown Object (File)
May 3 2024, 3:49 AM
Unknown Object (File)
Apr 29 2024, 3:54 PM
Subscribers

Details

Summary

Ref T7149. This works now, so enable it.

Test Plan
  • Uploaded large and small files in Firefox, Safari and Chrome.
  • Uploaded large files with arc upload.
  • Stopped/resumed large files with all clients.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Enable the chunk storage engine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
webroot/rsrc/js/core/DragAndDropFileUpload.js
267–274

This is a simplification: instead of reading the data into JS and then sending it in the request, we can send the Blob directly. This works in all modern browsers, and saves us some mess where Javascript decides to un-binary the data and re-encode it in JS UTF.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 15 2015, 6:07 PM
This revision was automatically updated to reflect the committed changes.