Page MenuHomePhabricator

Support a file data iteration interface for large files
ClosedPublic

Authored by epriestley on Mar 13 2015, 7:39 PM.
Tags
None
Referenced Files
F13266823: D12071.id29054.diff
Tue, May 28, 8:15 PM
F13247102: D12071.id29054.diff
Thu, May 23, 3:54 PM
F13238539: D12071.id29054.diff
Tue, May 21, 7:49 PM
F13238495: D12071.id.diff
Tue, May 21, 7:36 PM
F13238361: D12071.id29046.diff
Tue, May 21, 6:59 PM
F13227759: D12071.diff
Mon, May 20, 5:05 AM
F13214602: D12071.id29046.diff
Fri, May 17, 11:47 AM
F13209970: D12071.diff
Fri, May 17, 3:08 AM

Details

Summary

Ref T7149. A couple diffs down the line, this will let us emit chunked files without doing all the work up front or holding the entire file in RAM.

Test Plan

(Some newlines added for clarity.)

$ ./bin/files cat F942
ABCDEFGHIJKLMNOPQRSTUVWXYZ
$ ./bin/files cat F942 --begin 1
BCDEFGHIJKLMNOPQRSTUVWXYZ
$ ./bin/files cat F942 --end 10
ABCDEFGHIJ
$ ./bin/files cat F942 --begin 3 --end 5
DE
$

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Support a file data iteration interface for large files.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 13 2015, 10:31 PM
This revision was automatically updated to reflect the committed changes.