Page MenuHomePhabricator
Differential D11886

UI - add ability to customize header logo
ClosedPublic
Actions

Authored by btrahan on Feb 25 2015, 7:54 PM.
Tags
None
Referenced Files
F13234243: D11886.diff
Tue, May 21, 3:13 AM
F13229291: D11886.id.diff
Mon, May 20, 3:31 PM
F13213706: D11886.diff
Fri, May 17, 8:01 AM
F13183962: D11886.id.diff
Fri, May 10, 1:39 PM
F13183955: D11886.id28636.diff
Fri, May 10, 1:35 PM
F13183954: D11886.id28638.diff
Fri, May 10, 1:35 PM
F13176168: D11886.diff
Wed, May 8, 11:09 AM
Unknown Object (File)
Tue, May 7, 8:39 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Mountain of Wealth" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T4214: Allow installs to change or supplement the "Phabricator" icon
T7165: Change Phabricator logo for Phacility admin site
Commits
Restricted Diffusion Commit
rP315aa4b00095: UI - add ability to customize header logo
Summary

Fixes T7165. Let users specify a file phid in config, and then use that file via an inline style tag. Also, cache the URI so that we don't have to query the file on every page load.

Test Plan

custom_logo (1×1 px, 468 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 28636.Feb 25 2015, 7:54 PM
btrahan added a task: T7165: Change Phabricator logo for Phacility admin site.
btrahan retitled this revision from to UI - add ability to customize header logo.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptFeb 25 2015, 7:54 PM
btrahan mentioned this in F319050: custom_logo.Feb 25 2015, 7:54 PM
epriestley accepted this revision.Feb 25 2015, 7:59 PM
epriestley edited edge metadata.

Looks perfect to me.

src/applications/config/custom/PhabricatorCustomHeaderConfigType.php
4

fancy :o

This revision is now accepted and ready to land.Feb 25 2015, 7:59 PM
epriestley awarded a token.Feb 25 2015, 7:59 PM
Closed by commit rP315aa4b00095: UI - add ability to customize header logo (authored by btrahan, committed by btrahan). · Explain WhyFeb 25 2015, 8:00 PM
This revision was automatically updated to reflect the committed changes.
btrahan added a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Feb 25 2015, 8:07 PM
MZMcBride mentioned this in T4214: Allow installs to change or supplement the "Phabricator" icon.Jun 14 2015, 2:58 PM
• wasimsikder removed a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Aug 20 2015, 9:00 AM
avivey added a task: T4214: Allow installs to change or supplement the "Phabricator" icon.Aug 20 2015, 9:43 AM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
config/
custom/
42 lines
option/
23 lines
view/
page/
menu/
24 lines

Diff 28638

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/custom/PhabricatorCustomHeaderConfigType.php

Loading...
View Options

src/applications/config/option/PhabricatorCoreConfigOptions.php

Loading...
View Options

src/view/page/menu/PhabricatorMainMenuView.php

Loading...
Phabricator · Built by Phacility