Page MenuHomePhabricator

Implement more consistent publishing rules for repositories
ClosedPublic

Authored by epriestley on Feb 19 2015, 5:18 PM.
Tags
None
Referenced Files
F13239109: D11826.id28500.diff
Wed, May 22, 12:16 AM
F13238456: D11826.id28509.diff
Tue, May 21, 7:18 PM
F13215378: D11826.id28500.diff
Fri, May 17, 4:55 PM
F13214617: D11826.id28500.diff
Fri, May 17, 11:56 AM
F13196046: D11826.diff
Sun, May 12, 10:53 PM
F13184165: D11826.id28509.diff
Fri, May 10, 4:01 PM
F13178621: D11826.diff
Wed, May 8, 8:32 PM
Unknown Object (File)
Tue, May 7, 6:02 PM
Subscribers

Details

Summary

Ref T7298. We are currently inconsistent about when we publish feed, email, notifications, audits and Herald rules.

Specifically, there are two settings which impact these things:

  • The "importing" flag, which is set when we're importing old commits.
  • The "herald-disabled" flag, which was expanded in scope some time ago and now actually means "disable publishing".

Various parts of the pipeline were checking only one of these flags. Instead, all of them should check both.

(For example, we should never email users about importing repositories, nor trigger audits on them.)

Test Plan

See next revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable