Page MenuHomePhabricator

Transactions - fix bug in differential where older inlines weren't appearing
ClosedPublic

Authored by btrahan on Dec 5 2014, 6:19 PM.
Tags
None
Referenced Files
F14036548: D10935.diff
Sun, Nov 10, 10:43 AM
Unknown Object (File)
Oct 6 2024, 3:20 AM
Unknown Object (File)
Oct 6 2024, 3:20 AM
Unknown Object (File)
Oct 6 2024, 3:20 AM
Unknown Object (File)
Oct 6 2024, 3:12 AM
Unknown Object (File)
Sep 28 2024, 5:36 PM
Unknown Object (File)
Sep 17 2024, 7:35 AM
Unknown Object (File)
Sep 12 2024, 6:32 AM
Subscribers

Details

Summary

Fixes T6699. We need to "loadInlineComments" consistently, though for an unexpected reason - this mutates the $changesets to include all $changesets that have an associated inline comment, which is necessary to make them render properly.

Test Plan

Took a diff with inline comments and updated it, noting the inline comments disappeared. applied this patch and the inlines reappeared.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable