Hovercards - allow public access
ClosedPublic
Actions

Authored by btrahan on Oct 17 2014, 12:33 AM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6337: mentions don't show hovercards for logged-out users

Commits

Restricted Diffusion Commit
rP934eea2ef2a0: Hovercards - allow public access

Summary

see title

Test Plan

set config to allow public access and viewed a hovercard uri. saw a hovercard with little info as opposed to login prompt. Fixes T6337.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25738.Oct 17 2014, 12:33 AM

btrahan retitled this revision from to Hovercards - allow public access.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

btrahan added a task: T6337: mentions don't show hovercards for logged-out users.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 17 2014, 12:33 AM

chad accepted this revision.Oct 17 2014, 12:34 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 17 2014, 12:34 AM

Harbormaster completed remote builds in B2859: Diff 25738.Oct 17 2014, 12:34 AM

Closed by commit rP934eea2ef2a0: Hovercards - allow public access (authored by btrahan, committed by btrahan). · Explain WhyOct 17 2014, 12:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

controller/

PhabricatorSearchHovercardController.php

4 lines

Diff 25739

View Options

src/applications/search/controller/PhabricatorSearchHovercardController.php

Hovercards - allow public accessClosedPublicActions