Page MenuHomePhabricator

Generate expected schemata for User/People tables
ClosedPublic

Authored by epriestley on Sep 26 2014, 9:26 PM.
Tags
None
Referenced Files
F13257827: D10580.diff
Sun, May 26, 5:08 AM
F13253376: D10580.diff
Sat, May 25, 2:37 AM
F13231509: D10580.diff
Tue, May 21, 12:31 AM
F13209188: D10580.id25457.diff
Thu, May 16, 10:28 PM
F13205969: D10580.diff
Wed, May 15, 4:11 AM
Unknown Object (File)
Tue, May 7, 1:46 AM
Unknown Object (File)
May 2 2024, 8:42 PM
Unknown Object (File)
May 1 2024, 2:39 PM
Subscribers

Details

Summary

Ref T1191. Some notes here:

  • Drops the old LDAP and OAuth info tables. These were migrated to the ExternalAccount table a very long time ago.
  • Separates surplus/missing keys from other types of surplus/missing things. In the long run, my plan is to have only two notice levels:
    • Error: something we can't fix (missing database, table, or column; overlong key).
    • Warning: something we can fix (surplus anything, missing key, bad column type, bad key columns, bad uniqueness, bad collation or charset).
    • For now, retaining three levels is helpful in generating all the expected scheamta.
Test Plan
  • Saw ~200 issues resolve, leaving ~1,300.
  • Grepped for removed tables.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Generate expected schemata for User/People tables.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Give patches an umambiguous apply order.
This revision is now accepted and ready to land.Sep 30 2014, 4:44 PM
This revision was automatically updated to reflect the committed changes.