Page MenuHomePhabricator

Implement PhabricatorProjectInterface on ManiphestTask
ClosedPublic

Authored by epriestley on Aug 7 2014, 5:11 PM.
Tags
None
Referenced Files
F13261003: D10177.diff
Mon, May 27, 12:37 AM
F13252954: D10177.id.diff
Sat, May 25, 2:15 AM
F13243495: D10177.diff
Thu, May 23, 3:59 AM
F13223204: D10177.diff
Sun, May 19, 4:23 AM
F13209974: D10177.id24483.diff
Fri, May 17, 3:10 AM
F13208624: D10177.id24483.diff
Thu, May 16, 6:14 PM
F13207809: D10177.id24483.diff
Thu, May 16, 4:33 AM
F13183086: D10177.diff
Fri, May 10, 6:53 AM
Subscribers

Details

Summary

Ref T5245. This removes some hacks and activates two meaningful interactions:

  • The "projects" field goes through shared code now.
  • Mentioning projects in tasks using hashtags now tags them.
Test Plan
  • Viewed a task with projects.
  • Viewed a task with no projects.
  • Viewed a task with projects and board positions.
  • Viewed a revision with projects.
  • Made a #hashtag comment in Maniphest and got a project association.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Implement PhabricatorProjectInterface on ManiphestTask.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/project/events/PhabricatorProjectUIEventListener.php
53–55

I'm not touching this for now because I also want to redesign how the element looks and try giving these tags caret breadcrumbs, so you get:

(Project > Board)

...with the "Board" bit on a lighter background or something, and then eventually may get:

(Project > Subproject > Board)
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 7 2014, 7:43 PM
epriestley updated this revision to Diff 24498.

Closed by commit rP20d8b1bdd36a (authored by @epriestley).